[PATCH] D54217: Add total function byte size and inline function byte size to "llvm-dwarfdump --statistics"

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 09:39:26 PST 2018


dblaikie added a comment.

In https://reviews.llvm.org/D54217#1291793, @clayborg wrote:

> In https://reviews.llvm.org/D54217#1291170, @vsk wrote:
>
> > Looks reasonable to me, but it'd help to check in a .o for a test.
>
>
> There don't seem to be any tests for any of this. Are there existing tests for stuff that is only in llvm-dwarfdump? If so, please point me to where they are.


Where/how did you look for tests? I know they're not perfectly organized, but my usual approach is to search for some existing text nearby (in this case I searched the github for 'scope bytes covered' the statistic just before the ones you added - and I found this test case: https://github.com/llvm-mirror/llvm/blob/9d809925c655ce689c4a99025c180f15ac8a7a53/test/tools/llvm-dwarfdump/X86/statistics.ll ) or to look at the revision history of the feature I'm adding to & see what the last functional change was there, and if/how it was tested.


Repository:
  rL LLVM

https://reviews.llvm.org/D54217





More information about the llvm-commits mailing list