[PATCH] D54153: Fix compilation issue in VS2017 with Clang-tablegen and LLVM-tablegen

[Alexandre Ganea via Phabricator via llvm-commits]

aganea updated this revision to Diff 173172.
aganea added a comment.

Revert to target all generators.

In https://reviews.llvm.org/D54153#1291725, @rnk wrote:

> In https://reviews.llvm.org/D54153#1291543, @aganea wrote:
>
> > I managed to reproduce the issue with Ninja as well. It happens rarely, 1 out 5 runs.
>
>
> With that evidence, I definitely thing this extra, order-only dependency makes sense for all generators. Maybe add @beanz as a reviewer, he's the one that added this configuration, right?


My patch doesn't solve the Ninja issue I've mentioned above, could anybody help?


https://reviews.llvm.org/D54153

Files:
  cmake/modules/TableGen.cmake


Index: cmake/modules/TableGen.cmake
===================================================================
--- cmake/modules/TableGen.cmake
+++ cmake/modules/TableGen.cmake
@@ -165,6 +165,9 @@
         COMMENT "Building native TableGen..."
         USES_TERMINAL)
       add_custom_target(${project}-tablegen-host DEPENDS ${${project}_TABLEGEN_EXE})
+      if (NOT ${project} STREQUAL LLVM))
+        add_dependencies(${project}-tablegen-host LLVM-tablegen-host)
+      endif()
       set(${project}_TABLEGEN_TARGET ${project}-tablegen-host PARENT_SCOPE)
     endif()
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54153.173172.patch
Type: text/x-patch
Size: 576 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181108/306e0e37/attachment.bin>