[PATCH] D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally

[David Major via Phabricator via llvm-commits]

dmajor added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6155
+             "Frame alloc symbol should be a constant");
+      const MCConstantExpr *C = dyn_cast<MCConstantExpr>(Expr);
+
----------------
majnemer wrote:
> Since you already did an isa, this can be `cast<MCConstantExpr>(Expr)`.
I tried applying this patch (plus D53541, D51524, and D54248) and building Firefox, and I got a crash on null `Expr` here.

Let me know if you're interested in the repro, or if it's too early for me to be playing with this code, in which case sorry for the noise.



Repository:
  rL LLVM

https://reviews.llvm.org/D53540