[PATCH] D49362: [ThinLTO] Internalize read only globals

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM - just a couple of comments in the modified tests that need updates before commit. Thanks!



================
Comment at: test/Linker/funcimport.ll:14
 ; Ensure statics are promoted/renamed correctly from this file (all but
 ; constant variable need promotion).
 ; RUN: llvm-link %t.bc -summary-index=%t3.thinlto.bc -S | FileCheck %s --check-prefix=EXPORTSTATIC
----------------
Update comment.


================
Comment at: test/Linker/funcimport.ll:17
+; EXPORTSTATIC-DAG: @staticvar.llvm.{{.*}} = internal global
 ; Eventually @staticconstvar can be exported as a copy and not promoted
+; EXPORTSTATIC-DAG: @staticconstvar.llvm.0 = internal unnamed_addr constant
----------------
Update this comment - "Eventually" is now! =)


================
Comment at: test/Transforms/FunctionImport/funcimport.ll:83
 ; Ensure that all uses of local variable @P which has used in setfuncptr
 ; and callfuncptr are to the same promoted/renamed global.
+; CHECK-DAG: @P.llvm.{{.*}} = internal global void ()* null
----------------
update comment.


https://reviews.llvm.org/D49362