[PATCH] D54143: [WIP, RISCV] Generate address sequences suitable for mcmodel=medium

Lewis Revill via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 06:17:27 PST 2018


lewis-revill updated this revision to Diff 173152.
lewis-revill added a comment.

I fixed the segfault caused when the AsmPrinter attempts to use the BasicBlock to emit symbols which doesn't necessarily exist. This only occurred when symbols were being emitted for an MBB which had `AddressTaken` set to true, while the modifications for `LabelMustBeEmitted` allow a label to be emitted without the need for this.


Repository:
  rL LLVM

https://reviews.llvm.org/D54143

Files:
  include/llvm/CodeGen/MachineBasicBlock.h
  lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  lib/Target/RISCV/RISCVExpandPseudoInsts.cpp
  lib/Target/RISCV/RISCVISelLowering.cpp
  lib/Target/RISCV/RISCVISelLowering.h
  lib/Target/RISCV/RISCVInstrInfo.td
  lib/Target/RISCV/RISCVMCInstLower.cpp
  lib/Target/RISCV/Utils/RISCVBaseInfo.h
  test/CodeGen/RISCV/codemodel-lowering.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54143.173152.patch
Type: text/x-patch
Size: 15704 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181108/e95a14f2/attachment.bin>


More information about the llvm-commits mailing list