[PATCH] D54237: Constant folding and instcombine for saturating adds

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 02:30:59 PST 2018


nikic marked 5 inline comments as done.
nikic added inline comments.


================
Comment at: lib/Support/APInt.cpp:1953
+  APInt Res = sadd_ov(RHS, Overflow);
+  if (Overflow) {
+    if (isNegative()) {
----------------
bjope wrote:
> Coding style: skip all braces here.
I've left the braces on the overflow branch, otherwise there's a dangling else compiler warning.


https://reviews.llvm.org/D54237





More information about the llvm-commits mailing list