[PATCH] D54244: [HotColdSplitting] Refine definition of unlikelyExecuted

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

In https://reviews.llvm.org/D54244#1291193, @efriedma wrote:

> > This is motivated by functions like exit() and longjmp(), which are not beneficial to outline.
>
> exit() seems like a weird example: it executes at most once per process.  What's the downside of outlining it?


It’s not clear that there’s an actual benefit to outlining it. A call to exit(0) could be expected to happen: outlining it to a cold section might force a page fault when it otherwise wouldn’t.


https://reviews.llvm.org/D54244