[PATCH] D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`.

[Volodymyr Sapsai via Phabricator via llvm-commits]

vsapsai created this revision.
vsapsai added reviewers: bruno, benlangmuir.
Herald added subscribers: dexonsmith, hiraditya.

It fixes the case when Objective-C framework is added as a subframework
through a symlink. When parent framework infers a module map and fails
to detect a symlink, it would add a subframework as a submodule. And
when we parse module map for the subframework, we would encounter an
error like

> error: umbrella for module 'WithSubframework.Foo' already covers this directory

By implementing `getRealPath` "an egregious but useful hack" in
`ModuleMap::inferFrameworkModule` works as expected.

rdar://problem/45821279


https://reviews.llvm.org/D54245

Files:
  clang/test/VFS/subframework-symlink.m
  llvm/lib/Support/VirtualFileSystem.cpp
  llvm/unittests/Support/VirtualFileSystemTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54245.173097.patch
Type: text/x-patch
Size: 6442 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181108/20ca56d2/attachment.bin>