[PATCH] D54238: [llvm-strings] Fix whitespaces to match strings output.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 16:23:04 PST 2018


rupprecht created this revision.
rupprecht added a reviewer: jhenderson.
Herald added a subscriber: llvm-commits.

The current implementation prepends a space on every line, making it difficult to compare against GNU strings.

The space appears to have come from handling --radix in https://reviews.llvm.org/rL292707. The space is for making sure there's a space between the radix and the value; however the space is still emitted even when there is no radix. This change fixes that so the space is only emitted when there is a radix.


Repository:
  rL LLVM

https://reviews.llvm.org/D54238

Files:
  test/tools/llvm-strings/file-filename.test
  test/tools/llvm-strings/negative-char.test
  test/tools/llvm-strings/radix.test
  test/tools/llvm-strings/whitespace.test
  tools/llvm-strings/llvm-strings.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54238.173079.patch
Type: text/x-patch
Size: 4027 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181108/92e3cb0b/attachment.bin>


More information about the llvm-commits mailing list