[PATCH] D54228: AMDGPU/InsertWaitcnts: Simplify pending events tracking

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 15:56:56 PST 2018


t-tye added a comment.

> This is sufficient, because whenever only one event of a count type is

pending, its last time point is naturally the upper bound of all time
points of this count type, and when multiple event types are pending,
the count type has gone out of order and an s_waitcnt to 0 is required
to clear any pending event type (and will then clear all pending event
types for that count type).

Just wondered if can do better than using 0. Instead can the lowest count be used as this should be sufficient to ensure all out-of-order events in this have happened? I had discussed this with Bob at one time.


Repository:
  rL LLVM

https://reviews.llvm.org/D54228





More information about the llvm-commits mailing list