[PATCH] D54207: [ELF] Make TrapInstr and Filler byte arrays. NFC.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/ARM.cpp:64
   PltHeaderSize = 32;
-  TrapInstr = 0xd4d4d4d4;
+  TrapInstr = { 0xd4, 0xd4, 0xd4, 0xd4 };
   NeedsThunks = true;
----------------
I believe clang-format wouldn't add spaces after `{` and before `}`.


================
Comment at: ELF/OutputSections.cpp:242
+  bool NonZeroFiller =
+      llvm::support::endian::read32<endianness::native>(Filler.data()) != 0;
+  if (NonZeroFiller)
----------------
Do you need to use read32 if you only want to know whether a value is zero or not?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54207