[PATCH] D54217: Add total function byte size and inline function byte size to "llvm-dwarfdump --statistics"

[Greg Clayton via Phabricator via llvm-commits]

clayborg added a comment.

In https://reviews.llvm.org/D54217#1290504, @vsk wrote:

> In https://reviews.llvm.org/D54217#1290474, @aprantl wrote:
>
> > Thanks. There seems to be some overlap with
> >
> > [llvm-dev] RFC: Adding a code size analysis tool
> >  https://lists.llvm.org/pipermail/llvm-dev/2018-September/126501.html
> >
> > how was that discussion resolved?
>
>
> I think the response was generally positive but I haven't had the time to push things into tree. @clayborg, have you tried out the tool here: https://github.com/vedantk/llvm-project ? The RFC has some usage instructions.
>
> If you just want the ratio of inlined to not-inlined bytes, this patch is a simpler way to do it. But if you need something more fine-grained (i.e. *which* functions were inlined more compared to a baseline, by how much, etc.), it might be worth checking out. Happy to have someone else run with the code.


This current patch is indeed for an overview of inlined to not-inlined bytes. I have other patches to --statistics that will display more output coming. Breaking down exact sizes of inlined functions by count and size will be part of this future output. But this current one is just for a quick breakdown. Like you said in the URL provided, it is nice to know that say 30% of your code is inlined. If you are expecting less inlining and try a new option, this can be a quick way to see results in a very concise kind of way.


Repository:
  rL LLVM

https://reviews.llvm.org/D54217