[PATCH] D53887: [HotColdSplitting] Outline more than once per function

Jun Bum Lim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 12:52:11 PST 2018


junbuml added a comment.

> IMHO the right fix is to not treat noreturn calls as cold (also as a follow-up).

I'm not sure if handling noreturn is a right fix. A block containing exit(0) will have "unreachable", so it must be still considered as a cold block even after removing noreturn from unlikelyExecuted().


https://reviews.llvm.org/D53887





More information about the llvm-commits mailing list