[PATCH] D53710: [FileCheck] Warn if a prefix is only used in LABEL checks
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 7 12:20:23 PST 2018
jdenny added a comment.
In https://reviews.llvm.org/D53710#1290508, @probinson wrote:
> This seems like a reasonable use-case to me.
Agreed, but this test case shouldn't produce the warning because there's always an active prefix that has a non-LABEL directive. Or did I miss something?
I thought the point of the "shared label prefix" use case was to show a case of false positives. However, the examples that @SjoerdMeijer cited should produce the warning because they only use LABEL directives and thus are not legitimate use cases of LABEL.
https://reviews.llvm.org/D53710
More information about the llvm-commits
mailing list