[PATCH] D54078: Implement getpeername(2) interceptor

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:3090
+  __sanitizer_sockaddr_storage taddr;
+  int res = REAL(getpeername)(sockfd, addr ? &taddr : 0,
+                              addrlen ? &taddrlen : 0);
----------------
vitalybuka wrote:
> should we 
> ```
> if (addr)
>   COMMON_INTERCEPTOR_READ_RANGE(ctx, addrlen, sizeof(*addrlen));
> ```
> 
> before calling REAL
```
if (addr && addrlen)
  COMMON_INTERCEPTOR_READ_RANGE(ctx, addrlen, sizeof(*addrlen));
```


Repository:
  rL LLVM

https://reviews.llvm.org/D54078