[PATCH] D53492: [RISCV] Avoid unnecessary XOR for seteq/setne 0

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 09:03:36 PST 2018


asb added a comment.

Great catch, thanks. I know there's good test coverage for by virtue of it being a common pattern, but could you please add a more targeted unit test to e.g. test/CodeGen/RISCV/i32-icmp.ll? Otherwise, looks good to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D53492





More information about the llvm-commits mailing list