[llvm] r346333 - [llvm-exegesis] Remove superfluous move.

Clement Courbet via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 08:52:51 PST 2018


Author: courbet
Date: Wed Nov  7 08:52:50 2018
New Revision: 346333

URL: http://llvm.org/viewvc/llvm-project?rev=346333&view=rev
Log:
[llvm-exegesis] Remove superfluous move.

/Users/buildslave/as-bldslv9_new/lld-x86_64-darwin13/llvm.src/tools/llvm-exegesis/lib/X86/Target.cpp:155:12: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
    return std::move(Error);
           ^
/Users/buildslave/as-bldslv9_new/lld-x86_64-darwin13/llvm.src/tools/llvm-exegesis/lib/X86/Target.cpp:155:12: note: remove std::move call here
    return std::move(Error);
           ^~~~~~~~~~     ~

Modified:
    llvm/trunk/tools/llvm-exegesis/lib/X86/Target.cpp

Modified: llvm/trunk/tools/llvm-exegesis/lib/X86/Target.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/X86/Target.cpp?rev=346333&r1=346332&r2=346333&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-exegesis/lib/X86/Target.cpp (original)
+++ llvm/trunk/tools/llvm-exegesis/lib/X86/Target.cpp Wed Nov  7 08:52:50 2018
@@ -152,7 +152,7 @@ static llvm::Error IsInvalidOpcode(const
     return llvm::make_error<BenchmarkFailure>(
         "unsupported opcode: Push/Pop/AdjCallStack");
   if (llvm::Error Error = isInvalidMemoryInstr(Instr))
-    return std::move(Error);
+    return Error;
   // We do not handle instructions with OPERAND_PCREL.
   for (const Operand &Op : Instr.Operands)
     if (Op.isExplicit() &&




More information about the llvm-commits mailing list