[PATCH] D52930: [SCEV][NFC] Verify IR in isLoop[Entry, Backedge]GuardedByCond
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 7 04:28:05 PST 2018
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM.
In https://reviews.llvm.org/D52930#1267561, @mkazantsev wrote:
> Added notion of this option being slow. It can be later be turned on in EXPENSIVE_CHECKS mode along with the other two. I tried turning it on now and currently all three turned on fail 2 tests. Apparently a bug in there.
If there are failing tests, could you create a ticket so we can keep track of them?
================
Comment at: lib/Analysis/ScalarEvolution.cpp:166
+static cl::opt<bool> VerifyIR(
+ "scalar-evolution-verify-ir", cl::Hidden,
+ cl::desc("Verify IR correctness when making sensitive SCEV queries (slow)"),
----------------
Maybe change the name to something like `verify-scev-ir` to be more in line with the other verify flags?
https://reviews.llvm.org/D52930
More information about the llvm-commits
mailing list