[PATCH] D54185: [PowerPC][llvm-exegesis] Add a PowerPC target

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

Thanks for the patch !



================
Comment at: llvm/tools/llvm-exegesis/lib/CMakeLists.txt:13
+  add_subdirectory(PowerPC)
+  set(LLVM_EXEGESIS_TARGETS "${LLVM_EXEGESIS_TARGETS} PowerPC" PARENT_SCOPE)
+endif()
----------------
I think you wrote this against the version before PR39021 and failed to merge the changes in r342865.


================
Comment at: llvm/tools/llvm-exegesis/lib/PowerPC/Target.cpp:8
+//
+// Register PowerPC target with default latency benchmarks runner
+//===----------------------------------------------------------------------===//
----------------
"The PowerPC ExegesisTarget."


================
Comment at: llvm/tools/llvm-exegesis/lib/PowerPC/Target.cpp:32
+
+namespace {
+static unsigned GetLoadImmediateOpcode(unsigned RegBitWidth) {
----------------
remove the namespace; LLVM style does not put static functions in anonymous namespaces.


================
Comment at: llvm/tools/llvm-exegesis/lib/PowerPC/Target.cpp:33
+namespace {
+static unsigned GetLoadImmediateOpcode(unsigned RegBitWidth) {
+  switch (RegBitWidth) {
----------------
`getLoadImmediateOpcode`


================
Comment at: llvm/unittests/tools/llvm-exegesis/PowerPC/AnalysisTest.cpp:1
+#include "Analysis.h"
+
----------------
This file is missing a header.


================
Comment at: llvm/unittests/tools/llvm-exegesis/PowerPC/TargetTest.cpp:1
+#include "Target.h"
+
----------------
ditto


Repository:
  rL LLVM

https://reviews.llvm.org/D54185