[PATCH] D54179: [llvm-mca] Move the AssembleInput logic into its own class.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 6 22:03:11 PST 2018


mattd added a comment.

I started thinking about another way of organizing this patch, to reduce all of the potential extra files.  I can only really see two CodeRegion generators: one for ASM input, and the other for object file input... once we add the binary support.  Perhaps, we just have a CodeRegionGenerator.{h,cpp} and put the generators for ASM and object files in those instead of having separate header/implementations for ASM and Object files.  Just a  thought.


https://reviews.llvm.org/D54179





More information about the llvm-commits mailing list