[llvm] r346292 - [llvm-strip] Check "strip" with StringRef::contains instead of ends_with

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 6 19:02:11 PST 2018


Author: maskray
Date: Tue Nov  6 19:02:11 2018
New Revision: 346292

URL: http://llvm.org/viewvc/llvm-project?rev=346292&view=rev
Log:
[llvm-strip] Check "strip" with StringRef::contains instead of ends_with

Summary: If argv[0] is version suffixed, e.g. llvm-strip-7, this will still work.

Reviewers: rupprecht, jhenderson, alexshap, jakehehrlich

Reviewed By: rupprecht

Subscribers: alexshap, jakehehrlich, llvm-commits

Differential Revision: https://reviews.llvm.org/D54193

Modified:
    llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp

Modified: llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp?rev=346292&r1=346291&r2=346292&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp (original)
+++ llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp Tue Nov  6 19:02:11 2018
@@ -219,7 +219,7 @@ int main(int argc, char **argv) {
   InitLLVM X(argc, argv);
   ToolName = argv[0];
   DriverConfig DriverConfig;
-  if (sys::path::stem(ToolName).endswith_lower("strip"))
+  if (sys::path::stem(ToolName).contains("strip"))
     DriverConfig = parseStripOptions(makeArrayRef(argv + 1, argc));
   else
     DriverConfig = parseObjcopyOptions(makeArrayRef(argv + 1, argc));




More information about the llvm-commits mailing list