[PATCH] D54189: [HotColdSplitting] Ensure PHIs have unique incoming values

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 6 16:35:32 PST 2018


vsk created this revision.
vsk added reviewers: junbuml, sebpop, hiraditya, tejohnson.

Do not add a block to the outlining region if doing so would mean that
a PHI outside of the region would have incompatible incoming values from
the code replacer block.

Test case by Jun Bum Lim!

Fixes llvm.org/PR39564, rdar://45718012.

Depends on https://reviews.llvm.org/D53887.


https://reviews.llvm.org/D54189

Files:
  llvm/lib/Transforms/IPO/HotColdSplitting.cpp
  llvm/test/Transforms/HotColdSplit/outline-while-loop.ll
  llvm/test/Transforms/HotColdSplit/phi-with-distinct-outlined-values.ll
  llvm/test/Transforms/HotColdSplit/succ-block-with-self-edge.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54189.172879.patch
Type: text/x-patch
Size: 8524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181107/493eb54b/attachment.bin>


More information about the llvm-commits mailing list