[PATCH] D54154: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction

James Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 6 16:01:10 PST 2018


jrtc27 added a comment.

In https://reviews.llvm.org/D54154#1289602, @ruiu wrote:

> Or maybe `std::array<uint8_t, 4>` as it allows you to initialize it by writing `TrapInstr = {0xcc, 0xcc, 0xcc, 0xcc}` (which you cannot do if TrapInstr is a uint8_t[4]).


Ah, right, of course, I regard that as the same proposal just with nicer syntax! Happy to do the tiny amount of grunt work for that tomorrow if you both have better things to do with your time.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54154





More information about the llvm-commits mailing list