[PATCH] D54154: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction

[James Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

In https://reviews.llvm.org/D54154#1289531, @ruiu wrote:

> Maybe we probably should change the type of TrapInstr from uint32_t to uint8_t[4]?


That would make sense to clearly convey it's in the target endianness rather than the host; it's certainly a little surprising to have a `uint32_t` in the "wrong" endianness floating around. My only concern with making it an array is whether it's clear that you need to *repeat* the trap instruction if it's 1 or 2 bytes, but that same argument could be made for the current `uint32_t`, so probably irrelevant.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54154