[PATCH] D4276: Added llvm.is.constant intrinsic
James Y Knight via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 6 15:10:46 PST 2018
jyknight added a comment.
In https://reviews.llvm.org/D4276#1289427, @efriedma wrote:
> > The SCCP bug is already be exhibited by the tests in test/CodeGen/Generic/is-constant.ll which pass a struct.
>
> I'd prefer a testcase that explicitly calls "opt -sccp", as opposed to implicitly relying on the fact that opt -O2 includes SCCP. (You can just add a small test to test/Transforms/SCCP/ipsccp-basic.ll .)
Done. And verified that without the SCCP change, the test fails, and with it, passes.
https://reviews.llvm.org/D4276
More information about the llvm-commits
mailing list