[PATCH] D54124: [llvm-readelf] Make llvm-readelf more compatible with GNU readelf.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: tools/llvm-readobj/llvm-readobj.cpp:597
+  // -s has meant --sections for a very long time in llvm-readobj despite
+  // meaning something else in readelf.
+  static cl::alias SectionsShort("s", cl::desc("Alias for --sections"),
----------------
How about just `meaning --symbols in readelf`.

len(`--symbols`) < len(`something else`)    :)


================
Comment at: tools/llvm-readobj/llvm-readobj.cpp:649
 
-  if (sys::path::stem(argv[0]).find("readelf") != StringRef::npos)
+  if (sys::path::stem(argv[0]).find("readelf") != StringRef::npos) {
     opts::Output = opts::GNU;
----------------
`if (sys::path::stem(argv[0]).contains("readelf")) {`


Repository:
  rL LLVM

https://reviews.llvm.org/D54124