[PATCH] D54182: [Windows] Sink function bodies to .cpp file

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 6 13:48:20 PST 2018


rnk created this revision.
rnk added reviewers: zturner, aganea.
Herald added a subscriber: hiraditya.

These functions don't need to be inlined. I randomly picked Process.inc
for the Windows version helpers, since that's the most related file, and
Program.inc for MakeErrMsg since it's the main client.

While I'm here, move them into the llvm namespace, and delete the scoped
handle copy and assignment operators.


https://reviews.llvm.org/D54182

Files:
  llvm/lib/Support/Windows/Process.inc
  llvm/lib/Support/Windows/Program.inc
  llvm/lib/Support/Windows/WindowsSupport.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54182.172844.patch
Type: text/x-patch
Size: 8549 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181106/3d387298/attachment.bin>


More information about the llvm-commits mailing list