[PATCH] D53887: [HotColdSplitting] [WIP] Outline more than once per function

[Jun Bum Lim via Phabricator via llvm-commits]

junbuml added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:282
     // that it's cold.
-    assert(!OutF->hasFnAttribute(Attribute::OptimizeNone) &&
-           "An outlined function should never be marked optnone");
-    OutF->addFnAttr(Attribute::MinSize);
+    markEntireFunctionCold(*OutF);
 
----------------
Considering the case below, I believed we should not mark the MinSize here as well. 


```
void foo(bool c) {
  if(c) {
    ....
    return;
  }

   // hot code
   exit (0);
}
```


https://reviews.llvm.org/D53887