[PATCH] D54129: [AArch64] [Windows] Trap after noreturn calls.
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 6 10:12:06 PST 2018
rnk added a comment.
We came up with a different solution for this called `SEH_Epilogue`. It basically inserts a nop if the last real instruction was a call. It's slightly complicated because it looks backwards across empty basic blocks and things. You can see it here:
https://github.com/llvm-mirror/llvm/blob/master/lib/Target/X86/X86MCInstLower.cpp#L1800
I'd rather take that approach. I don't like that just going to Windows gets you this extra trapping behavior. That should be something else that the user controls. Otherwise soon they'll start relying on it. =/
Repository:
rL LLVM
https://reviews.llvm.org/D54129
More information about the llvm-commits
mailing list