[PATCH] D50200: AMDGPU: Handle "uniform-work-group-size" attribute
Aakanksha Patil via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 6 09:29:23 PST 2018
aakanksha555 added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp:221
+ while(!SortedNodeList.empty()) {
+ CallGraphNode *Node = SortedNodeList.pop_back_val();
+ Function *Caller = Node->getFunction();
----------------
arsenm wrote:
> You aren't using this as a stack, so this is weird. You could just do a range loop on reverse(SortedNodeList)
I used pop_back since I wanted the last element first. I'll change it to a range loop.
https://reviews.llvm.org/D50200
More information about the llvm-commits
mailing list