[PATCH] D54153: Fix compilation issue in VS2017 with Clang-tablegen and LLVM-tablegen

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 6 08:38:47 PST 2018


aganea added a comment.

In https://reviews.llvm.org/D54153#1288814, @zturner wrote:

> Unfortunately I can't read your output log, but I'm a little bit concerned that we're making a change to the dependency graph for what seems to be a problem only with the Visual Studio generator (or, at least, nobody has ever observed this problem with any other build system).  Is the dependency actually correct?


The issue is that XXX-tablegen-host .vcxprojects are explicitly calling `cmake --build`, thus not going through MSBuild's dependency graph. It looks like the Ninja generator doesn't do that.
I can make this hack specific to the "Visual Studios" generators.


Repository:
  rL LLVM

https://reviews.llvm.org/D54153





More information about the llvm-commits mailing list