[PATCH] D53710: [FileCheck] Warn if a prefix is only used in LABEL checks

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

Hi Joel, thanks for taking another look!

> The warning is still misleading when there are multiple prefixes. See my earlier inline comment. The easiest solution is probably to reword so that it never mentions a specific prefix.

Ah, missed that I think.

> I know you ran test/CodeGen/ARM, but did you try any other test suites? This is only a warning, but changes to FileCheck have impact throughout LLVM, so it would nice to get a better preview of what others will see before pushing.

Good point. Will do my homework and get back soon with an update.


https://reviews.llvm.org/D53710