[PATCH] D54153: Fix compilation issue in VS2017 with Clang-tablegen and LLVM-tablegen

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 6 07:55:32 PST 2018


nhaehnle added a comment.

Interesting. Thanks for digging into buildsystem stuff!



================
Comment at: cmake/modules/TableGen.cmake:168-170
+      if (${project} STREQUAL CLANG)
+        add_dependencies(CLANG-tablegen-host LLVM-tablegen-host)
+      endif()
----------------
Seems to me that this should logically rather something like:
```
if (NOT ${project} STREQUAL LLVM)
  add_dependencies(${project}-tablegen-host LLVM-tablegen-host)
endif()
```


Repository:
  rL LLVM

https://reviews.llvm.org/D54153





More information about the llvm-commits mailing list