[PATCH] D54143: [WIP, RISCV] Generate address sequences suitable for mcmodel=medium
James Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 6 03:05:50 PST 2018
jrtc27 requested changes to this revision.
jrtc27 added inline comments.
This revision now requires changes to proceed.
================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:362
+ SDValue AddrHi = getTargetNode(N, DL, Ty, DAG, Flags | RISCVII::MO_PCREL_HI);
+ SDValue AddrLo = getTargetNode(N, DL, Ty, DAG, Flags | RISCVII::MO_LO);
+ SDValue MNHi = SDValue(DAG.getMachineNode(RISCV::AUIPC, DL, Ty, AddrHi), 0);
----------------
This needs to be an `MO_PCREL_LO`, surely? (and then modified to refer to the `auipc` rather than the symbol...)
Repository:
rL LLVM
https://reviews.llvm.org/D54143
More information about the llvm-commits
mailing list