[PATCH] D54140: [XRay] Use TSC delta encoding for custom/typed events

[Marcus Boerger via Phabricator via llvm-commits]

mboerger added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_fdr_logging.cc:157
+        // function records use deltas instead of full TSCs and rely on other
+        // metadata records for TSC wraparound and CPU migration)
+        H.Version = 5;
----------------
why'd you not add dots at the end, these comments are all sentences.


================
Comment at: llvm/lib/XRay/RecordInitializer.cpp:178
+
+  assert(OffsetPtr > BeginOffset &&
+         OffsetPtr - BeginOffset <= MetadataRecord::kMetadataBodySize);
----------------
why assert and not return an error?


https://reviews.llvm.org/D54140