[PATCH] D54139: [XRay] Update XRayRecord to support Custom/Typed Events

[Marcus Boerger via Phabricator via llvm-commits]

mboerger added inline comments.


================
Comment at: llvm/include/llvm/XRay/XRayRecord.h:68
+/// records may not correspond to actual entries in the raw traces, but they are
+/// the logical representation of records in a higher-level log of events.
 struct XRayRecord {
----------------
...higher-level event-log.


================
Comment at: llvm/include/llvm/XRay/XRayRecord.h:70
 struct XRayRecord {
-  /// The type of record.
+  /// The type of record. By default, we represent function call records (value
+  /// = 0), and for custom events we use 1. For Typed Event records, we use the
----------------
Please clarify how RecordType and Type work together. And it is sad that there is no initial enum, but that may just be me.


https://reviews.llvm.org/D54139