[PATCH] D49025: [XRay] basic mode PID and TID always fetch

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added a comment.

In https://reviews.llvm.org/D49025#1288182, @krytarowski wrote:

> This test seems to have a Linux assumption and I have concerns how to port it to NetBSD.
>
> On NetBSD TIDs start from 1 to N in each process. Each process has a single distinct PID. TID numbers are not unique between processes (they are unique only within a process). PID numbers are unique.
>
> On Linux TID is effectively PID and this is linuxism.


Right, I'm missing the concern here -- the change actually records both PID and TID by getting them regularly instead of caching them at the start of the thread.

Does this fail in NetBSD and if it does, what is the failure mode?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49025