[PATCH] D53975: Start adding the supporting code to perform out-of-process allocator enumeration.

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added a comment.

Can you please be more specific about what exactly are you objecting against? We really want the code for the out-of-process enumeration to be part of compiler-rt, otherwise we'll be getting downstream failures forever. And in compiler-rt, the code belongs to the allocator.

We might be able to improve on this further, if you explain what specifically you don't like: The IsLocal checks are needed because the code modifies memory. We could change the function to have another bool argument that would specify whether modifications are allowed or not.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D53975