[PATCH] D54122: [LLD] Fix precompiled headers build break on Linux

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 5 15:15:01 PST 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/trunk/COFF/PDB.cpp:680-682
     sys::fs::make_absolute(CurrentPath);
 
     StringRef CurrentFileName = sys::path::filename(CurrentPath);
----------------
Do we really need to make each object file path absolute before calling sys::path::filename? I would've expected we could just do `StringRef CurrentFileName = sys::path::filename(F->getName());`.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54122





More information about the llvm-commits mailing list