[PATCH] D54114: Adding debug info to support Fortran (part 2)
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 5 13:59:40 PST 2018
aprantl requested changes to this revision.
aprantl added a comment.
This revision now requires changes to proceed.
Thanks. I have a couple of high-level points before we can go into more specific details:
The LLVM IR debug info metadata is effectively DWARF with a different syntax. Why is a Fortran-specific array / bounds node necessary oruseful, when DWARF doesn't have one?
DISubrange is the wrong place to hold a DIExpression; this won't work with optimized code. Instead, there should be a DIFlagArtificial variable for the lower and upper bound that is described with a llvm.dbg.value / llvm.dbg.declare and the dbg.value/declare should reference the DIExpression. This way the expression can be updated when the code is transformed by the optimizer.
Repository:
rL LLVM
https://reviews.llvm.org/D54114
More information about the llvm-commits
mailing list