[PATCH] D54116: [GlobalISel] Refactor the artifact combiner a bit by using MIPatternMatch

Volkan Keles via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 5 11:46:05 PST 2018


volkan marked an inline comment as done.
volkan added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:74
+      ;
+
+    // zext(trunc x) - > and (aext/copy/trunc x), mask
----------------
aditya_nandakumar wrote:
> Looks like this patch is not NFC (Is it meant to be?). Looks like the check for isInstUnsupported has been dropped here. Is that intended?
It was not, I updated the patch.


https://reviews.llvm.org/D54116





More information about the llvm-commits mailing list