[PATCH] D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added inline comments.


================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:1382
 
-  if (!eliminateDeadStores(F, AA, MD, DT, TLI))
+  DenseMap<Value *, MemoryLocationFlags> CachedMemLocFlags;
+  if (!eliminateDeadStores(F, AA, MD, DT, TLI, CachedMemLocFlags))
----------------
Could this go inside eliminateDeadStores(F, ...)?


================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:1415
 
-    return eliminateDeadStores(F, AA, MD, DT, TLI);
+    DenseMap<Value *, MemoryLocationFlags> CachedMemLocFlags;
+    return eliminateDeadStores(F, AA, MD, DT, TLI, CachedMemLocFlags);
----------------
Same as above.


Repository:
  rL LLVM

https://reviews.llvm.org/D53203