[PATCH] D53594: [GlobalISel] Introduce G_BUILD_VECTOR and G_CONCAT_VECTOR opcodes

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/MachineIRBuilder.cpp:554
+      getMRI()->getType(Res).getElementType().getSizeInBits())
+    return buildBuildVector(Res, Ops);
+  MachineInstrBuilder MIB = buildInstr(TargetOpcode::G_BUILD_VECTOR_TRUNC);
----------------
aemerson wrote:
> aditya_nandakumar wrote:
> > What's your take on just passing this to buildBuildVector vs asserting here?
> I chose to redirect to buildBuildVector because I assumed that when you're using MachineIRBuilder you're interested in the overall semantics rather than with specific opcode is generated.
Fair enough. Please update the documentation for the Opcode as well to reflect this.


Repository:
  rL LLVM

https://reviews.llvm.org/D53594