[PATCH] D51861: [LSR] Combine unfolded offset into invariant register

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 5 08:55:06 PST 2018


qcolombet added inline comments.


================
Comment at: test/Transforms/LoopStrengthReduce/two-combinations-bug.ll:2
+; RUN: opt < %s -loop-reduce -disable-output -debug-only=loop-reduce |& FileCheck %s
+; REQUIRES: asserts
+
----------------
Could you reduce the test even more?
E.g., I usually had some success by adding an assert for the case that interests me and bugpoint on this specific assert (via custom script)

Could we check that the transformation looks good instead of checking the debug output?
Put differently can we write a test that works for release as well?


https://reviews.llvm.org/D51861





More information about the llvm-commits mailing list