[PATCH] D54096: [WebAssembly] Add support for the event section

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 5 03:09:51 PST 2018


aheejin added a comment.

- I tried to add support for `.eventtype` printing and parsing in the same vein as https://reviews.llvm.org/D54012 and https://reviews.llvm.org/D53842, but ended up only adding printing support for now because of PR39557 <https://bugs.llvm.org/show_bug.cgi?id=39557>. (This is talking about adding '.functype' parsing support, but adding '.eventtype' parsing support is the same because it also uses `WasmSignature`).
- Currently `test/Object/wasm-string-outside-section.test` fails with this patch. This test case is testing a malformed custom section, and I have to update the test case binary to include the new event section to maintain the same failure behavior (otherwise this fails before it reaches the custom section). This test was added in https://reviews.llvm.org/D50387 and I don't know how this test was generated. Asked the author about it.


Repository:
  rL LLVM

https://reviews.llvm.org/D54096





More information about the llvm-commits mailing list