[PATCH] D54089: [MergeICmps] Do not perform the transformation if GEP is used outside of block
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 5 01:39:52 PST 2018
courbet accepted this revision.
courbet added a comment.
This revision is now accepted and ready to land.
> I think checking isUsedOutsideOfBlock with GEP is the original intention of the code, as the checking for LoadI is already performed in the same function.
Indeed, this is a typo.
Thanks a lot.
================
Comment at: test/Transforms/MergeICmps/X86/gep-used-outside.ll:6
+
+; The entry block is part of the chain. It however can not be merged. We need to make the
+; first comparison block in the chain the new entry block of the function.
----------------
please update the comment.
Repository:
rL LLVM
https://reviews.llvm.org/D54089
More information about the llvm-commits
mailing list