[PATCH] D54081: Add new interceptor for atof(3)

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7256
+#if SANITIZER_INTERCEPT_ATOF
+INTERCEPTOR(double, atof, char *nptr) {
+  void *ctx;
----------------
const char?



================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7260
+  if (nptr)
+    COMMON_INTERCEPTOR_READ_RANGE(ctx, nptr, REAL(strlen)(nptr) + 1);
+  return REAL(atof)(nptr);
----------------
atof does not scan full string


================
Comment at: test/sanitizer_common/TestCases/NetBSD/atof.cc:7
+int main(void) {
+  double d;
+
----------------
shouldn't it be a Posix test?


Repository:
  rL LLVM

https://reviews.llvm.org/D54081