[PATCH] D53496: AMDGPU: Rewrite SILowerI1Copies to always stay on SALU

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 4 13:38:56 PST 2018


nhaehnle added a comment.

In https://reviews.llvm.org/D53496#1282412, @hakzsam wrote:

> This regresses the following tests on RADV:
>
> dEQP-VK.glsl.loops.special.for_uniform_iterations.select_iteration_count_fragment,Fail
>  dEQP-VK.glsl.loops.special.for_uniform_iterations.select_iteration_count_vertex,Fail
>  dEQP-VK.glsl.loops.special.while_uniform_iterations.select_iteration_count_fragment,Fail
>  dEQP-VK.glsl.loops.special.while_uniform_iterations.select_iteration_count_vertex,Fail


The change exposed a bug in the SIInsertWaitcnts pass. I'm working on a fix.

It's quite likely that https://bugs.freedesktop.org/show_bug.cgi?id=108611 is the same bug, but I haven't confirmed that yet.


Repository:
  rL LLVM

https://reviews.llvm.org/D53496





More information about the llvm-commits mailing list