[PATCH] D33878: Handle NetBSD specific _Unwind_Ptr

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 4 07:52:15 PST 2018


krytarowski requested review of this revision.
krytarowski added inline comments.
Herald added a subscriber: chrib.


================
Comment at: lib/builtins/gcc_personality_v0.c:248
             _Unwind_SetGR(context, __builtin_eh_return_data_regno(0),
-                          (uintptr_t)exceptionObject);
+                          (TYPE_UNWIND_PTR)exceptionObject);
             _Unwind_SetGR(context, __builtin_eh_return_data_regno(1), 0);
----------------
compnerd wrote:
> `_Unwind_SetGR` is declared as: `void _Unwind_SetGR(struct _Unwind_Context *, int, _Unwind_Word);`
> 
> So this cast should not be needed.
Pity on NetBSD this is:

`void _Unwind_SetGR(struct _Unwind_Context *, int, _Unwind_Ptr);`

So the 3rd argument differs.


Repository:
  rL LLVM

https://reviews.llvm.org/D33878





More information about the llvm-commits mailing list