[PATCH] D54083: [X86][AVX512] Remove constant pool shuffle deciding from SelectionDAG

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 4 03:37:54 PST 2018


RKSimon created this revision.
RKSimon added a reviewer: craig.topper.
Herald added a subscriber: chrib.

This patch removes the last use of the constant pool shuffle decode helper and consistently uses the 'getTargetShuffleMaskIndices' versions instead. The constant pool versions are now purely used for assembly comments.

The avx512vbmi instrinsic upgrades had to be altered as they were being decoded as broadcasts, similar to what I fixed in https://reviews.llvm.org/rL346032. I don't think the change is critical - although its annoying that we lose the {k}{z} instruction, on vpermi2 it's not that useful....


Repository:
  rL LLVM

https://reviews.llvm.org/D54083

Files:
  lib/Target/X86/X86ISelLowering.cpp
  test/CodeGen/X86/avx512vbmi-intrinsics-upgrade.ll
  test/CodeGen/X86/avx512vbmivl-intrinsics-upgrade.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54083.172518.patch
Type: text/x-patch
Size: 8552 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181104/efa5f59f/attachment.bin>


More information about the llvm-commits mailing list